taskset.c should add these lines:
#include <sched.h> for sched_getaffinity, etc
#include <stddef.h> for size_t
#include <string.h> for memset
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
$ ionice 123
none: prio 4
none: prio 4
It calls ioprio_get(0x1, 0) and ioprio_get(0x1, 123), because the
code does not check it the "-p" options was specified.
The proper command line syntax is:
$ ionice -p 123
and the ioprio_get() should be called only once.
Signed-off-by: Karel Zak <kzak@redhat.com>
* make the code more robust
* follow kernel conventions for variable names
(data = classdata, ioprio = classdata | class)
Signed-off-by: Karel Zak <kzak@redhat.com>
chrt.c:158:16: warning: comparison of integers of different
signs: 'int' and 'unsigned long' [-Wsign-compare]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
fsck.minix.c: In function ‘map_block2’:
fsck.minix.c:486:9: warning: array subscript is above array bounds [-Warray-bounds]
The 'blknr' has to be bigger than 7 + 256 + (256 * 256) for i_zone[9].
Signed-off-by: Karel Zak <kzak@redhat.com>
* 'minix' of https://github.com/kerolasa/lelux-utiliteetit:
libblkid: move MINIX_MAXPARTITIONS to minix.h
minix: move globals and inline functions to minix_programs.h
libblkid: use MINIX_BLOCK_SIZE from minix.h
libblkid: use superblock structure from minix.h
include: move minix.h to include directory
include: remove kernel headers from minix.h
include: minix.h: use data types from stdint.h
Conflicts:
disk-utils/Makefile.am
Signed-off-by: Karel Zak <kzak@redhat.com>
tab_parse.c:mnt_parse_mountinfo_line parses "none" in src as NULL,
tab_update.c:fprintf_mtab_fs sets m1 to NULL instead of "none" and
returns -ENOMEM
tab_update.c:update_table says "write entry failed: Success", as errno
hasn't been set, and gotos to leave, leaving mtab not updated.
Addresses-debian-bug: 634871
Reported-by: Tomas Janousek <tomi@nomi.cz>
Signed-off-by: Karel Zak <kzak@redhat.com>
Global variables and inline functions are moved from minix.h to
minix_programs.h which is included in mkfs.minix and fsck.minix.
The minix.h will have only struct definitions etc generic
contents which is reasonable to share with utilities and
libraries.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
In the minix.h two definitions where renamed, so that the single
definition is reusable in fsck.minix, mkfs.minix and libblkid.
BLOCK_SIZE_BITS -> MINIX_BLOCK_SIZE_BITS
BLOCK_SIZE -> MINIX_BLOCK_SIZE
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This clean up is purely cosmetic. Perprocessor could never use
the includes as KERNEL_INCLUDES_ARE_CLEAN variable does not get
set anywhere.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
An element declared as size_t cannot be detected as negative (len < 0)
is always false.
This can lead to an infinite loop causing a segmentation fault.
Check if len is equal to -1 or -2 instead
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
* sami/mkfs.bfs:
docs: add long options to mkfs.bfs.8
mkfs.bfs: coding style fix
mkfs.bfs: include-what-you-use header check
mkfs.bfs: validate numeric user inputs
mkfs.bfs: use xstrdup from xalloc.h
mkfs.bfs: add long options
mkfs.bfs: use libc error facilities
* sami/isosize:
docs: isosize.8 add long options
isosize: fix coding style
isosize: include-what-you-use header check
isosize: check user input to be numeric
isosize: use long options
isosize: remove global variables
-u : print kernel messages
-k : print userspace message
The options could be mixed together or with --facility option too.
Signed-off-by: Karel Zak <kzak@redhat.com>
This patch adds support for books in cpu topology output. Books are
currently only present on the s390 architecture, however it looks like
others will follow to use the extra scheduling domain of the kernel.
Books are logically between sockets and nodes. In order to not break
any existing tools that might parse the output of lscpu the output
is changed so that books will follow nodes:
CPU,Core,Socket,Node,Book
In addition the readable output is changed from
"CPU socket(s):" to "Socket(s) per book:" or simply "Socket(s):" in the
absence of books.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Add queue request size parameter.
Very useful for tuning multipath performance.
Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Add device state column. For normal disk it could be running or offline,
for device-mapper devices running or suspended.
Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
For v3 minix superblocks the state flag (s_state) has been removed, so drop it
from the structure in accordance with the kernel's representation.
Reported-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Sami Kerola
Karel Zak
Marc-Antoine Perennou
Heiko Carstens
Milan Broz
Davidlohr Bueso