Commit Graph

731 Commits

Author SHA1 Message Date
Sami Kerola ec3bc7aaf4 whereis: align with howto-usage-function.txt
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-03-19 16:03:19 +01:00
Sami Kerola 3bfb96365d whereis: add search scope listing option
Mostly useful when debugging why the command does, or does not, work.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-19 16:02:32 +01:00
Sami Kerola 9db54a7e08 whereis: rewrite most of the command
The earlier code gave little or no change to fix bugs and improve the
command.  This rewrite attempts to make further patching easier.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Co-Author: Karel Zak <kzak@redhat.com>
2013-03-19 15:44:45 +01:00
Karel Zak 16ef36f783 docs: add TB to list of supported suffixes
Reported-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-18 18:31:07 +01:00
Karel Zak 58a3cee647 chkdupexe: remove, deprecated for years
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-14 13:34:11 +01:00
Karel Zak 426f0ceac7 findmnt: add FREQ and PASSNO columns
... to provide all information from fstab.

Reported-by: Roger Leigh <rleigh@codelibre.net>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-14 10:50:37 +01:00
Karel Zak f546276e22 kill: support --list=<signal>
The '=' is expected for optional arguments and required in procps version.

Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-13 16:02:55 +01:00
Sami Kerola fda84b66ee kill: add pretty printed list output (for compatibility with procps)
* add -L, --table

References: http://www.freelists.org/post/procps/kill1-consolidation
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-13 15:47:12 +01:00
Karel Zak f1e7f7d54e kill: use new API from lib/procutils.c
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-12 17:40:31 +01:00
Sami Kerola 9e068ce0f1 docs: add long options and tidy up kill.1
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-03-12 15:24:33 +01:00
Sami Kerola ea72260cbe kill, procs: use pid_t for pids
Reference: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/threads.h#n30
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-12 15:24:04 +01:00
Sami Kerola 44e5fcddc0 kill: use libc error printing facilities and exit values
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-12 14:42:21 +01:00
Sami Kerola a5618319e6 kill: align with howto-usage-function.txt
[kzak@redhad.com: - s/commandname/name/
                  - improve --all description
                  - add -h/--help]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-03-12 14:41:13 +01:00
Sami Kerola daa54393bc kill: add long options
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-03-12 14:31:42 +01:00
Benno Schulenberg ceefa682b4 docs: improve wording, grammar and formatting of lsblk man page
Also sort the options alphabetically.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2013-03-04 12:33:31 +01:00
Benno Schulenberg 3768420374 docs: improve grammar and formatting of explanation of "-o +list"
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2013-03-04 12:33:25 +01:00
Karel Zak e346233ea2 findmnt: allow to read (PART)UUID/LABEL from udev DB
Currently findmnt uses libmount to get filesystem properties (and
libmount uses libblkid). This works as expected, but root permissions
are required to read the tags from the devices.

It seems better to read the information from udev db and use libblkid
as fallback solution only.

Signed-off-by: Karel Zak <kzak@redhat.com>
2013-02-18 15:00:57 +01:00
Karel Zak d44e3391b7 lsblk: resuse udev handler
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-02-18 13:37:00 +01:00
Karel Zak 36fb10074c docs: add missing information about -o +<list>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-02-18 13:30:00 +01:00
Karel Zak e68948e146 lslocks: support -o +<list> convention
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-02-18 13:21:42 +01:00
Karel Zak 7badb909e2 lslocks: add BLOCKER column
BLOCKER -  PID of the process blocking the lock

Signed-off-by: Karel Zak <kzak@redhat.com>
2013-02-18 13:12:01 +01:00
Karel Zak 55c0d16bab lslocks: detect blocked locks, fix /proc/locks parser
$ flock foo -c "sleep 100" & flock foo -c "sleep 100"

old version:
  $ lslocks
  lslocks: failed to parse pid: 'WRITE'

new version:

COMMAND           PID  TYPE  SIZE MODE   M      START        END PATH
[...]
flock            1318 FLOCK    0B WRITE* 0          0          0 /home/projects/
flock            1319 FLOCK    0B WRITE  0          0          0 /home/projects/

 The asterisk (e.g. WRITE*) is used for blocked processes.

Reported-by: Mantas Mikulenas <grawity@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-02-14 16:29:51 +01:00
Karel Zak 07c916cfdd lslocks: use libmount to parse mountinfo
old version:
	$ strace -e open lslocks 2>&1 | grep mountinfo | wc -l
	118

new version:
	strace -e open ./lslocks 2>&1 | grep mountinfo | wc -l
	1

Reported-by: Bernhard Voelker <mail@bernhard-voelker.de>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-02-14 15:59:28 +01:00
Sami Kerola f8bd089b1d a pointer should not be compared to zero [coccinelle]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-02-06 11:51:15 +01:00
Benno Schulenberg b50945d4ac textual: spell and encode the name of Arkadiusz Miśkiewicz correctly
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2013-02-06 11:15:02 +01:00
Karel Zak 6a0766444d libblkid: remove optimization from verify( funrtion
Now libblkid (the cache based part) tries to probe for the cached
filesystem firstly. This optimization is broken, because:

  * new another superblock could be on the device and the original
    is already obsolete
  * we still need to probe for partitions and raids
  * the code was too fragile

The patch also suggests lsblk --fs in blkid.8 for end users. lsblk
read information from used db.

Reported-by: Andreas Hofmeister <andi@collax.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-02-01 15:59:58 +01:00
Benno Schulenberg 2e1d40c63f textual: fix the example in whereis man page, plus further improvements
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2013-01-30 15:41:20 +01:00
Sami Kerola 540dfebe3e rename: make usage() translator friendly
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-01-25 16:40:05 +01:00
Sami Kerola 39b232c169 lsblk: make usage() translator friendly
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-01-25 16:40:04 +01:00
Sami Kerola ff2bd506db findmnt: make usage() translator friendly
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-01-25 16:40:04 +01:00
Karel Zak e421313dc2 textual: use UTIL_LINUX_VERSION everywhere
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-25 12:05:26 +01:00
Benno Schulenberg 217615e8ed textual: standardize reporting of program name plus package version
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2013-01-25 11:47:29 +01:00
Benno Schulenberg 8c219bf463 textual: gettextize several overlooked messages
Also improve the clarity of some of them.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2013-01-25 11:47:29 +01:00
Benno Schulenberg 095345d07d textual: fix a few typos in some of the usage help texts
Also improve clarity of some other lines of those texts.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2013-01-25 11:47:26 +01:00
Karel Zak e66ba1bfaf cal: don't mix ncurses output functions and printf()
Fedora 18 (ncurses-libs-5.9-7.20121017, glibc-2.16-28):

$ cal | cat
Actual results:
    January 2013    Su Mo Tu We Th Fr Sa       1  2  3  4  5 6  7  8
9 10 11 1213 14 15 16 17 18 1920 21 22 23 24 25 2627 28 29 30 31

Not sure where is the problem, but it's too fragile to mix two
output methods in one code.

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=896447
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-17 18:48:16 +01:00
Karel Zak 31f67453a3 findmnt: use tree output in more cases
It seems that we can create the tree also if output is restricted by
fstype or options filter, for example

	$ findmnt -t cgroups

Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-17 12:08:09 +01:00
Karel Zak 741587f3e9 kill: add note about threads to the man page
Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=846790
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-15 11:18:28 +01:00
Karel Zak 3e373967ec findmnt: make --target usable with bind mounts
The --target <non-mount-point> functionality should be enabled only if
previous regular search found nothing to avoid collisions with bind
mounts, because to detect mountpoint we use traditional child / parent
stat.st_dev comparison which does not work for bind mounts (--bind /A
/A).

Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-14 14:50:50 +01:00
Karel Zak 624f2b47c3 findmnt: add PROPAGATION column
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-10 15:59:16 +01:00
Karel Zak 9238e0fa33 findmnt: add ID column
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-10 14:59:39 +01:00
Karel Zak 327ea85a73 findmnt: add OPT-FIELDS column
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-10 14:58:05 +01:00
Sami Kerola bc6d983403 build-sys: ignore chkdupexe
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2013-01-10 11:26:59 +01:00
Milan Broz 2adb1a44c2 lsblk: Add write-same attribute to topology info
Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
2013-01-07 18:12:02 +01:00
Karel Zak 46d4ce56a7 lslocks: fix compiler warnings
Signed-off-by: Karel Zak <kzak@redhat.com>
2012-12-20 19:57:48 +01:00
Karel Zak dd5c22a679 blkid: fix double free [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
2012-12-12 20:48:15 +01:00
Karel Zak 7a591a1fb5 namei: don't care about xasprintf() return code
Signed-off-by: Karel Zak <kzak@redhat.com>
2012-12-12 12:12:25 +01:00
Karel Zak 0d7ebfc4a7 lslocks: don't care about xasprintf() return code
Signed-off-by: Karel Zak <kzak@redhat.com>
2012-12-12 12:11:17 +01:00
Karel Zak b5fd07bcdb lsblk: don't care about xasprintf() return code
Signed-off-by: Karel Zak <kzak@redhat.com>
2012-12-12 12:09:44 +01:00
Karel Zak 60b17c6f0e findmnt: don't care about xasprintf() return code
Signed-off-by: Karel Zak <kzak@redhat.com>
2012-12-12 12:08:06 +01:00
Karel Zak c717b0328d rename: use macro to print version
Signed-off-by: Karel Zak <kzak@redhat.com>
2012-12-10 13:14:38 +01:00