Commit Graph

12 Commits

Author SHA1 Message Date
Sami Kerola 7ee26cbf02 maint: fix shadow declaration
This change fixes all shadow declarations.  The worth while to mention
fix is with libfdisk sun geometry.  It comes from bitops.h cpu_to_be16
macro that further expands from include/bits/byteswap.h that has the
shadowing.

libfdisk/src/sun.c:961:173: warning: declaration of '__v' shadows a previous local [-Wshadow]
libfdisk/src/sun.c:961:69: warning: shadowed declaration is here [-Wshadow]
libfdisk/src/sun.c:961:178: warning: declaration of '__x' shadows a previous local [-Wshadow]
libfdisk/src/sun.c:961:74: warning: shadowed declaration is here [-Wshadow]

That could have caused earlier some unexpected results.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2015-01-07 10:08:21 +01:00
Benno Schulenberg 451dbcfae1 textual: add a docstring to most of the utilities
This adds a concise description of a tool to its usage text.

A first form of this patch was proposed by Steven Honeyman
(see http://www.spinics.net/lists/util-linux-ng/msg09994.html).

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2015-01-06 11:27:38 +01:00
Steven Honeyman 0a55b319d4 zramctl: fixed two -Wformat-security warnings
(they prevented compilation if -Werror=format-security is enabled)

Signed-off-by: Steven Honeyman <stevenhoneyman@users.noreply.github.com>
2014-09-15 21:59:31 +01:00
Sami Kerola 1fa6c3e0b9 zramctl: improve option combination error messaging
Use of --algorithm or --streams is not expected to work without
reseting device, that happens when --size is specified, so ensure the
former options to be combined with the later.

[kzak@redhat.com: - make it more generic]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
2014-08-11 14:47:08 +02:00
Karel Zak 342436c66a zramctl: cannonicalize devname when no fullpath specified
Signed-off-by: Karel Zak <kzak@redhat.com>
2014-08-11 14:39:46 +02:00
Sami Kerola 929c7b2817 zramctl: improve error message
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
2014-08-11 14:27:13 +02:00
Karel Zak 116c9ce23d zramctl: fail status printout when device does not exist
Signed-off-by: Karel Zak <kzak@redhat.com>
2014-08-11 14:26:20 +02:00
Karel Zak 423c0d75ec zramctl: remove extra \n from usage()
Signed-off-by: Karel Zak <kzak@redhat.com>
2014-08-06 15:04:58 +02:00
Karel Zak b07ca5160c zramctl: fix typo
Signed-off-by: Karel Zak <kzak@redhat.com>
2014-08-06 09:02:09 +02:00
Karel Zak 6ed7f01127 zramctl: fix typo
Reported-by: Steven Honeyman
Signed-off-by: Karel Zak <kzak@redhat.com>
2014-08-05 15:47:36 +02:00
Benno Schulenberg 1c35e62517 zramctl: fix the wording of some message strings
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2014-08-05 15:37:41 +02:00
Karel Zak 0624d8406b zrmactl: add new command to control /dev/zramN devices
Co-Author: Timofey Titovets <nefelim4ag@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
2014-08-01 12:09:55 +02:00