This patch fixes several issues:
1. lscpu may not exist on all systems.
2. Option -b is not always available but we can skip it because it's
the documented default for -p.
3. Some old lscpu versions print --help output to stdout in case of
error. So in case 2. it would count all the help lines as CPUs,
which could be really bad on slow single core machines.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
All other test output goes to builddir too and moreover "make distcheck"
complains about writing to it's read-only srcdir.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Unarguably this change makes test output to be more messy, but when I
compare run time tells with clear numbers parallel is quicker. For me
the quickness is important factor. Running test suite always after a
change is preferrably quick, and if something is indicated to be broken
it is ok to spend time in drilling down what happen.
$ time ./tests/run.sh --parallel=5
[...]
real 1m48.037s
Same without parallelization.
$ time ./tests/run.sh
real 3m16.687s
The default is changed to be parallel, where job count is same as number
of CPUs.
[kzak@redhat.com: - propagate --parallel into function.sh
- don't use extra title for non-parallel execution
- disable by default]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
The command 'make check' is called from 'make distcheck' (which is
used to generate official util-linux tarballs).
It means that tests/ stuff has to be compatible with autotools and
differentiate between source and build directories.
* remove run-nonroot.sh (merged into run.sh
* remove commands.sh.in
* all tests and top level run.sh accept --builddir and --srcdir
command line options
* functions.sh modified to use $top_builddir/tests for output files
Signed-off-by: Karel Zak <kzak@redhat.com>
The previous "gplv2-only" was copy&past mistake. This re-licensing is
correct -- there is not any other contributor to this code.
Signed-off-by: Karel Zak <kzak@redhat.com>
The "." command will search $PATH before $PWD if the argument
specified contains no path qualifiers which can cause problems if
you happen to have something in $PATH named the same. The
attached patch changes all of the ". <foo>" in the tests subdir.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
The patch adds tests/ directory with simple regression tests infrastructure.
Also, it adds the "ts-mount-paths" test that testing if all defined paths
(fstab, mtab, locks) are still same.
Signed-off-by: Karel Zak <kzak@redhat.com>
Ruediger Meier
Ondrej Oprala
Sami Kerola
Karel Zak
Mike Frysinger