ericonr
/
util-linux
mirror of https://github.com/ericonr/util-linux.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fsck.cramfs: segfault with INCLUDE_FS_TESTS and no -x option 

The current implementation causes a segmentation fault if
INCLUDE_FS_TESTS is defined, but the -x option is not specified.

The error is caused by the extract_dir variable being null.

Reported-by: Roy Peled <the.roy.peled@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
This commit is contained in:
Karel Zak 2009-02-04 23:36:39 +01:00
parent 3ff2557c92
commit a6f72ab47e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
disk-utils/fsck.cramfs.c
View File

@ -67,7 +67,7 @@ struct cramfs_super super; /* just find the cramfs superblock once */
static int cramfs_is_big_endian = 0; /* source is big endian */
static int opt_verbose = 0; /* 1 = verbose (-v), 2+ = very verbose (-vv) */
char *extract_dir = NULL; /* extraction directory (-x) */
char *extract_dir = ""; /* extraction directory (-x) */
/* Exit codes used by fsck-type programs */
#define FSCK_OK 0 /* No errors */
@ -314,7 +314,8 @@ static void print_node(char type, struct cramfs_inode *i, char *name)
}
printf("%c %04o %s %5d:%-3d %s\n",
type, i->mode & ~S_IFMT, info, i->uid, i->gid, name);
type, i->mode & ~S_IFMT, info, i->uid, i->gid,
!*name && type == 'd' ? "/" : name);
}
/*