ericonr
/
util-linux
mirror of https://github.com/ericonr/util-linux.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

rename: use readlink() in more robust way 

Reported-by: Jan Pazdziora <jpazdziora@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
This commit is contained in:
Karel Zak 2021-06-17 13:25:43 +02:00
parent aec0e37683
commit 9461ae9b90
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
misc-utils/rename.c
View File

@ -105,6 +105,7 @@ static int do_symlink(char *from, char *to, char *s, int verbose, int noact,
{
char *newname = NULL, *target = NULL;
int ret = 1;
ssize_t ssz;
struct stat sb;
if ( faccessat(AT_FDCWD, s, F_OK, AT_SYMLINK_NOFOLLOW) != 0 &&
@ -125,12 +126,15 @@ static int do_symlink(char *from, char *to, char *s, int verbose, int noact,
return 2;
}
target = xmalloc(sb.st_size + 1);
if (readlink(s, target, sb.st_size + 1) < 0) {
ssz = readlink(s, target, sb.st_size + 1);
if (ssz < 0) {
warn(_("%s: readlink failed"), s);
free(target);
return 2;
}
target[sb.st_size] = '\0';
target[ssz] = '\0';
if (string_replace(from, to, target, target, &newname) != 0)
ret = 0;