sfdisk: remove unnecessary size check [cppcheck]
Following warning is false positive. Size of the buffer is defined using BUFSIZ, and so the strncpy() will never overwrite the last byte that is initialized to zero in get_user_reply(). [disk-utils/sfdisk.c:137] -> [disk-utils/sfdisk.c:136]: (warning) Either the condition 'bufsz!=0' is redundant or strncpy() argument nr 3 can have invalid value. The value is -1 but the valid values are '0:'. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
parent
4ac2ab97d1
commit
84f46d1f67
|
@ -134,8 +134,6 @@ static int get_user_reply(const char *prompt, char *buf, size_t bufsz)
|
||||||
if (!p)
|
if (!p)
|
||||||
return 1;
|
return 1;
|
||||||
strncpy(buf, p, bufsz - 1);
|
strncpy(buf, p, bufsz - 1);
|
||||||
if (bufsz != 0)
|
|
||||||
buf[bufsz - 1] = '\0';
|
|
||||||
free(p);
|
free(p);
|
||||||
} else
|
} else
|
||||||
#endif
|
#endif
|
||||||
|
|
Loading…
Reference in New Issue