fallocate: use O_CREAT only for the default behavior

Reported-by: Bernhard Voelker <mail@bernhard-voelker.de>
Signed-off-by: Karel Zak <kzak@redhat.com>
This commit is contained in:
Karel Zak 2014-06-26 14:45:02 +02:00
parent 38a5440c95
commit 575718a04a
1 changed files with 3 additions and 1 deletions

View File

@ -364,7 +364,9 @@ int main(int argc, char **argv)
if (offset < 0)
errx(EXIT_FAILURE, _("invalid offset value specified"));
fd = open(filename, O_RDWR|O_CREAT, 0644);
/* O_CREAT makes sense only for the default fallocate(2) behavior
* when mode is no specified and new space is allocated */
fd = open(filename, O_RDWR | (!dig && !mode ? O_CREAT : 0), 0644);
if (fd < 0)
err(EXIT_FAILURE, _("cannot open %s"), filename);