ericonr
/
util-linux
mirror of https://github.com/ericonr/util-linux.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lib: simplify cpuset if clauses that return 

There is no need for 'else' when 'if' will return.  In same go move call of
tolower() to last possible moment in char_to_val(), a lot of time hex values
should hit 0-9 range, and it can be omitted.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2017-05-29 18:39:22 +01:00 committed by Karel Zak
parent f4d3783867
commit 35e82b2926
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/cpuset.c
View File

@ -29,23 +29,21 @@ static inline int val_to_char(int v)
{
if (v >= 0 && v < 10)
return '0' + v;
else if (v >= 10 && v < 16)
if (v >= 10 && v < 16)
return ('a' - 10) + v;
else
return -1;
return -1;
}
static inline int char_to_val(int c)
{
int cl;
cl = tolower(c);
if (c >= '0' && c <= '9')
return c - '0';
else if (cl >= 'a' && cl <= 'f')
cl = tolower(c);
if (cl >= 'a' && cl <= 'f')
return cl + (10 - 'a');
else
return -1;
return -1;
}
static const char *nexttoken(const char *q, int sep)