ericonr
/
sndio
mirror of https://github.com/ericonr/sndio.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

remove misleading XXXs and TODOs

This commit is contained in:
Alexandre Ratchov 2012-12-01 13:13:57 +01:00
parent b3f82753f8
commit eff8e25982
3 changed files with 2 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sndiod/dsp.c
View File

@ -570,7 +570,7 @@ cmap_add(struct cmap *p, void *in, void *out, int vol, int todo)
istart = p->istart; istart = p->istart;
inext = p->inext; inext = p->inext;
nch = p->nch; nch = p->nch;
v = vol; /* XXX */ v = vol;
/* /*
* map/mix input on the output * map/mix input on the output

9
sndiod/midi.c
View File

@ -14,12 +14,6 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/ */
/*
* TODO
*
* use shadow variables (to save NRPNs, LSB of controller)
* in the midi merger
*/
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
@ -217,7 +211,7 @@ midi_tag(struct midi *ep, unsigned int tag)
} }
/* /*
* broadcast the given message to other members of the thru box * broadcast the given message to other endpoints
*/ */
void void
midi_send(struct midi *iep, unsigned char *msg, int size) midi_send(struct midi *iep, unsigned char *msg, int size)
@ -257,7 +251,6 @@ midi_send(struct midi *iep, unsigned char *msg, int size)
} }
} }
/* /*
* determine if we have gained more input tickets, and if so call the * determine if we have gained more input tickets, and if so call the
* fill() call-back to notify the i/o layer that it can send more data * fill() call-back to notify the i/o layer that it can send more data

6
sndiod/sock.c
View File

@ -925,7 +925,6 @@ sock_hello(struct sock *f)
} }
s->mix.maxweight = f->opt->maxweight; s->mix.maxweight = f->opt->maxweight;
s->dup = f->opt->dup; s->dup = f->opt->dup;
/* XXX: must convert to slot rate */
f->slot = s; f->slot = s;
return 1; return 1;
} }
@ -1398,7 +1397,6 @@ sock_buildmsg(struct sock *f)
} }
if (f->midi != NULL && f->midi->obuf.used > 0) { if (f->midi != NULL && f->midi->obuf.used > 0) {
/* XXX: use tickets */
size = f->midi->obuf.used; size = f->midi->obuf.used;
if (size > AMSG_DATAMAX) if (size > AMSG_DATAMAX)
size = AMSG_DATAMAX; size = AMSG_DATAMAX;
@ -1518,7 +1516,6 @@ sock_read(struct sock *f)
f->wtodo = sizeof(struct amsg); f->wtodo = sizeof(struct amsg);
f->rstate = SOCK_RMSG; f->rstate = SOCK_RMSG;
f->rtodo = sizeof(struct amsg); f->rtodo = sizeof(struct amsg);
/* XXX: call sock_wmsg() ? */
#ifdef DEBUG #ifdef DEBUG
if (log_level >= 4) { if (log_level >= 4) {
sock_log(f); sock_log(f);
@ -1555,9 +1552,6 @@ sock_write(struct sock *f)
f->wtodo = 0xdeadbeef; f->wtodo = 0xdeadbeef;
break; break;
} }
/*
* XXX: why not set f->wtodo in sock_wmsg() ?
*/
f->wstate = SOCK_WDATA; f->wstate = SOCK_WDATA;
f->wsize = f->wtodo = ntohl(f->wmsg.u.data.size); f->wsize = f->wtodo = ntohl(f->wmsg.u.data.size);
/* PASSTHROUGH */ /* PASSTHROUGH */