ericonr
/
erm
mirror of https://github.com/ericonr/erm.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove dead code. 

There's no occasion when queue_remove won't succeed or call exit(), as
handled by the while loop above it, so we can also switch it to a void
function.
This commit is contained in:
Érico Nogueira 2021-10-27 17:17:29 -03:00
parent e323a9e59e
commit 37e4158aa8
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
remove.c
View File

@ -80,9 +80,8 @@ error:
return rv;
}
static inline int queue_remove(struct queue *q, struct task *t)
static inline void queue_remove(struct queue *q, struct task *t)
{
int rv = 0;
pthread_mutex_lock(&q->mtx);
while (q->len == 0) {
if (q->free == nproc - 1) {
@ -93,17 +92,12 @@ static inline int queue_remove(struct queue *q, struct task *t)
pthread_cond_wait(&q->cond, &q->mtx);
q->free--;
}
if (q->len == 0) {
rv = EAGAIN;
goto error;
}
queue_print(q);
*t = q->tasks[--(q->len)];
/* the caller owns the path buffer now */
error:
pthread_mutex_unlock(&q->mtx);
return rv;
}
static inline void recurse_into_parents(struct task *t)